Skip to content

Simplify utility implementations in spring-core #33903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Simplify utility implementations in spring-core #33903

wants to merge 12 commits into from

Conversation

polyglot-k
Copy link
Contributor

You just received a pull request, so I changed the format similar to that.

  • enhancement by adding early return
  • delete the unnecessary 'else'

@polyglot-k
refactor: Simplify Util code in Spring-core directory
fae73d4 
- enhancement by adding early return
- delete the unnecessary 'else'
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 17, 2024
@sbrannen sbrannen added the type: task A general task label Nov 17, 2024
@sbrannen sbrannen self-assigned this Nov 17, 2024
sbrannen

This comment was marked as outdated.

Sign in to view

@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 17, 2024
@sbrannen sbrannen changed the title Simplify Util code in Spring-core parts Simplify utility implementations in spring-core Nov 17, 2024
@polyglot-k polyglot-k requested a review from sbrannen November 17, 2024 12:18
@polyglot-k

This comment was marked as outdated.

Sign in to view
sbrannen
sbrannen requested changes Nov 17, 2024
View reviewed changes
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 17, 2024
@polyglot-k polyglot-k requested a review from sbrannen November 17, 2024 12:28
@polyglot-k
Copy link
Contributor Author

@sbrannen
I'm not used to contributing, but thank you for your meticulous review

sbrannen
sbrannen requested changes Nov 17, 2024
View reviewed changes
@polyglot-k polyglot-k requested a review from sbrannen November 17, 2024 12:55
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 17, 2024
@polyglot-k

This comment was marked as outdated.

Sign in to view
@sbrannen

This comment was marked as outdated.

Sign in to view
@sbrannen sbrannen removed the status: feedback-provided Feedback has been provided label Nov 17, 2024
@sbrannen sbrannen added this to the 6.2.1 milestone Nov 17, 2024
sbrannen added a commit that referenced this pull request Nov 17, 2024
@sbrannen
Update copyright headers
7f78193 
See gh-33903
@sbrannen sbrannen closed this in 2494ecb Nov 17, 2024
@polyglot-k
Copy link
Contributor Author

Thank you for your good review of the long work :)
Have a nice day today.

@sbrannen
Copy link
Member

This has been merged into 6.2.x and main in 2494ecb.

After merging, I noticed the copyright headers had not been updated, so I did that in 7f78193.

Thanks for the PR and for making all of the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen Awaiting requested review from sbrannen

Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
6.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@polyglot-k @sbrannen @spring-projects-issues