feat(astro): add "Download lesson as zip" button #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
commented
Nov 13, 2024
AriPerkkio
force-pushed
the
feat/download-zip
branch
2 times, most recently
from
623f32c to
79c37f7
Compare
AriPerkkio
force-pushed
the
feat/download-zip
branch
from
79c37f7 to
1b5daef
Compare
Nemikolh
reviewed
Nov 14, 2024
Comment on lines
+18
to
+20
| if (!lesson) { | ||
| throw new Error('Missing lesson'); | ||
| } |
There was a problem hiding this comment.
Oh I suppose we are throwing here because this can only happen in development if there's a bug? 👀
There was a problem hiding this comment.
This is only to make Typescript happy 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.