Skip to content

Extract exe path logic #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

katrinabrock
Copy link
Contributor

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

This logic will be reused in the initiate method for #1022 work. For now just breaking it into its own function.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute of Animal Behavior

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! windows-oldrel failures will be fixed by #1082

@katrinabrock
Copy link
Contributor Author

hmm...I just rebased and things seem to have gotten worse.

@jgabry
Copy link
Member

jgabry commented Apr 29, 2025

hmm...I just rebased and things seem to have gotten worse.

Looks like now windows-oldrel is passing but there are some ubuntu failures. They seem unrelated to this PR and more like some intermittent failures that we see with GitHub Actions from time to time.

@katrinabrock
Copy link
Contributor Author

so then is there anything stopping this from being merged?

@jgabry
Copy link
Member

jgabry commented Apr 30, 2025

I just restarted the checks that failed. Looks like the test coverage one is still failing for the same reason (I don’t think that failure should prevent us from merging this). The one for the unit tests on Ubuntu with r-devel now seems to be running and has made it past where it failed last time. So I guess let’s let that one finish and then merge this unless it fails for some reason related to the PR (seems unlikely).

@jgabry
Copy link
Member

jgabry commented Apr 30, 2025

so then is there anything stopping this from being merged?

Merging now. Sorry, forgot to say yesterday that I was going to try re-running the failed checks.

@jgabry jgabry merged commit 68b5862 into stan-dev:master Apr 30, 2025
18 of 21 checks passed
@katrinabrock
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants