Skip to content

feat: bump crewjam/saml to v0.5.1 #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: bump crewjam/saml to v0.5.1 #2001

wants to merge 1 commit into from

Conversation

hf
Copy link
Contributor

@hf hf commented Apr 25, 2025

Includes this change which fixes #1925.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14665740278

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.448%

Totals Coverage Status
Change from base Build 14664006937: 0.0%
Covered Lines: 10886
Relevant Lines: 15675

💛 - Coveralls

@crewjam
Copy link

crewjam commented Apr 25, 2025

Please note the discussion here: crewjam/saml#605

We are actually reverted the change and are actively looking for test cases to understand the correct behavior.

kangmingtay
kangmingtay previously approved these changes Apr 25, 2025
@kangmingtay kangmingtay dismissed their stale review April 25, 2025 13:51

see issue above

@hf
Copy link
Contributor Author

hf commented Apr 25, 2025

Oh OK will find test cases for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAML SSO fails when SAML response elements inherit a parent's default namespace
4 participants