Skip to content

Remove symfony/phpunit-bridge from test-pack #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove symfony/phpunit-bridge from test-pack #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
239b2aa
Remove phpunit-bridge from test-pack
alexander-schranz Mar 19, 2025
7bea7a6
Not restrict version longer as phpunit bridge not longer here
alexander-schranz Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@
"license": "MIT",
"description": "A pack for functional and end-to-end testing within a Symfony app",
"require": {
"phpunit/phpunit": "^9.5",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was only restricted to this version because of the bridge: #19

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth setting ^11.1 here, given that is the first PHPUnit version that is fully compatible with the features provided by PHPUnitBridge's deprecation system? Or would that be redundant, as Composer will automatically pick the latest version anyways?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should then be >=11.1 IMHO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on symfony/recipes#1401 (comment), we may need to set this to some >=12.x version then. That could probably mean we have to delay this to Symfony 7.4?

Copy link
Author

@alexander-schranz alexander-schranz Apr 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the "pack" behave with >= does it still require it as ^11.1 else a conflict would be better.

"phpunit/phpunit": "*",
"symfony/browser-kit": "*",
"symfony/css-selector": "*",
"symfony/phpunit-bridge": "*"
"symfony/css-selector": "*"
},
"require-dev": {
"phpunit/phpunit": "^9.5",
"phpunit/phpunit": "*",
"symfony/browser-kit": "*",
"symfony/css-selector": "*",
"symfony/phpunit-bridge": "*"
"symfony/css-selector": "*"
}
}