chore(notification-channels): Make Slack webhook URL fields sensitive #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dbonf merged 1 commit into sysdiglabs:master from akahenry:slack-webhook-url-sensitive

Apr 28, 2025

Contributor

akahenry commented Apr 26, 2025

Slack webhook URLs are sensitive according to Slack documentation (https://api.slack.com/messaging/webhooks):

Keep it secret, keep it safe. Your webhook URL contains a secret. Don't share it online, including via public version control repositories. Slack actively searches out and revokes leaked secrets.

This PR makes them sensitive in Terraform as well so they don't get sent to logs and unexpectedly exposed.


          Make Slack webhook URL fields sensitive

0d94686

akahenry requested review from michelevergnano, dkutsanov, antonio-cuomo and dbonf as code owners

April 26, 2025 20:31

dbonf approved these changes

View reviewed changes

Collaborator

dbonf left a comment

thanks for this contribution, it makes totally sense, so, lgtm

dbonf merged commit 8f2a0a4 into sysdiglabs:master

41 of 45 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dbonf dbonf approved these changes

michelevergnano Awaiting requested review from michelevergnano michelevergnano is a code owner

dkutsanov Awaiting requested review from dkutsanov dkutsanov is a code owner

antonio-cuomo Awaiting requested review from antonio-cuomo antonio-cuomo is a code owner

Labels

None yet