Skip to content

fix: ignore-order-of-controls #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025
Merged

fix: ignore-order-of-controls #640

merged 5 commits into from
May 22, 2025

Conversation

ishtayger
Copy link
Collaborator

requirement.controls is a set so that reordering from API does not get picked up as false change for example:

 ~ control {
    ~ name    = "A" -> "B"
  }
~ control {
    ~ name    = "B" -> "A"
  }

dbonf
dbonf previously approved these changes May 21, 2025
tembleking
tembleking previously approved these changes May 21, 2025
@ishtayger ishtayger dismissed stale reviews from tembleking and dbonf via c8a42b5 May 21, 2025 14:55
fix test

fix test
@ishtayger ishtayger force-pushed the ignore-order-of-controls branch from d9178c1 to dbbdf39 Compare May 21, 2025 15:07
@ishtayger ishtayger merged commit f9d57d8 into master May 22, 2025
56 of 59 checks passed
@ishtayger ishtayger deleted the ignore-order-of-controls branch May 22, 2025 14:40
@tembleking tembleking mentioned this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants