Allow inline assembly #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could your code handle all variations of inline assembly syntax found in GNU-compatible compilers like Clang, including |
It can handle I didn't find any document of |
Simply search |
jserv
requested changes
Apr 17, 2025
Change-Id: If67148de2637a02fc44597700745056b846d7f32
lumynou5
force-pushed
the
allow-inline-asm
branch
from
a0ed7dc to
cfddc51
Compare
Previously, fmtscan would report spelling in inline assembly and block committing. It supports the 'asm', '__asm__', and '__asm' keywords. According to the GCC documentation, the 'asm' keyword is a GNU extension and the alternative '__asm__' can be used when writing code compiled with '-ansi' and various '-std' options, and '__asm' is a historical keyword that the current documentation doesn't mention. Closes: sysprog21#292 Change-Id: I9564c47a6ae67278a9b0c42ee0087d597c9c33ab
Cppcheck cannot recognize the GNU extension of explicit register
variables:
register int x asm("eax");
This commit suppresses syntax error to prevent explicit register
variables being blocked. It also makes real syntax error suppressed, but
it doesn't affect much while real ones lead to compile-time errors and
can be found early.
Change-Id: I603fa80083ba935c7de706546f77bac616da6fcc
lumynou5
force-pushed
the
allow-inline-asm
branch
from
cfddc51 to
6385c40
Compare
|
Thank @lumynou5 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is an attempt to enable inline assembly not being blocked by the checks.
Previously, fmtscan would report spelling in inline assembly and block committing, so an additional check is added to skip identifiers that are
asmand contents in a pair of parentheses following them.Also, Cppcheck cannot recognize the GNU extension of explicit register variables:
This patch suppresses syntax error to prevent explicit register variables being blocked. It also makes real syntax error suppressed, but it doesn't affect much while real ones lead to compile-time errors and can be found early.