add /.export-stats endpoint to dump stats table #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also worth noting that the stats are aggregate (within their time periods) and do not include any user data about who clicked on which links. Hence why this is fine to expose to all users that can access the golink instance. |
willnorris
force-pushed
the
will/export-stats
branch
from
df1199d to
db5ee33
Compare
mikeodr
approved these changes
Apr 22, 2025
| http.Error(w, err.Error(), http.StatusInternalServerError) | ||
| } | ||
| }() | ||
|
|
There was a problem hiding this comment.
Should the header be added to the output?
Suggested change
| fmt.Fprint(w, "link ID, UNIX timestamp, and click count") | |
There was a problem hiding this comment.
maybe? The data is pretty simple, and I'm not sure what this is going to get imported into and whether it can easily ignore header rows. I'll probably leave it off for now, and just document it on the help page once we're sure this works how we need. We can always add the header later as well.
This is really bare bones, but at least lets us get the stats data out. This also made it clear to me how brittle some of our tests are because of how much global state we have in the top-level golink package. We should probably move all of that into a server type or something similar before too long. Updates #168 Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
willnorris
force-pushed
the
will/export-stats
branch
from
db5ee33 to
942f955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really bare bones, but at least lets us get the stats data out. This also made it clear to me how brittle some of our tests are because of how much global state we have in the top-level golink package. We should probably move all of that into a server type or something similar before too long.
Updates #168
Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d