Skip to content

feat: Add support for private ca certs #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrobinson1022
Copy link

Added support for private CA acm certificates

Description

Added the following attribute and corresponding variable:

certificate_authority_arn = var.private_authority_arn
variable "private_authority_arn" {
  description = "Private Certificate Authority ARN for issuing private certificates"
  type        = string
  default     = null
}

Motivation and Context

This allows the module to be used for private CA's to issue ACM certificates.

Breaking Changes

There should be no breaking change with this. The variable default is null so not having it declared should not result in any changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

added example for private CA
@mrobinson1022 mrobinson1022 changed the title feat: add support for private ca certs feat: Add support for private ca certs Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant