Skip to content

test: run against ESLint v9 #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 18, 2024
Merged

test: run against ESLint v9 #926

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
152e242
test: introduce flat compat rule tester
G-Rath Aug 14, 2024
5daaa0d
test: remove duplicate cases
G-Rath Aug 14, 2024
2776757
test: expect no output change with `null`
G-Rath Aug 14, 2024
0d6bb40
ci: test against ESLint v9
G-Rath Aug 14, 2024
fe6f534
ci: uninstall some packages for v9 to avoid an npm inf. loop bug
G-Rath Aug 15, 2024
4cfd5e2
ci: timeout after 3 minutes
G-Rath Aug 15, 2024
db55860
ci: uninstall more packages for inf. loop
G-Rath Oct 17, 2024
8d487d5
test: be consistent with comments
G-Rath Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/verifications.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,26 @@ jobs:
tests:
name: Tests (Node v${{ matrix.node }} - ESLint v${{ matrix.eslint }})
runs-on: ubuntu-latest
timeout-minutes: 3
strategy:
fail-fast: false
matrix:
node: [12.22.0, 12, 14.17.0, 14, 16, 17, 18, 19, 20, 22]
eslint: [7.5, 7, 8]
eslint: [7.5, 7, 8, 9]
exclude:
# eslint@9 doesn't support < Node v18
- node: 17
eslint: 9
- node: 16
eslint: 9
- node: 14
eslint: 9
- node: 14.17.0
eslint: 9
- node: 12
eslint: 9
- node: 12.22.0
eslint: 9
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -49,6 +64,10 @@ jobs:
- name: Install dependencies
run: npm install

# see https://github.com/npm/cli/issues/7349
- if: ${{ matrix.eslint == 9 }}
run: npm un @typescript-eslint/eslint-plugin eslint-plugin-jest eslint-doc-generator

- name: Install ESLint v${{ matrix.eslint }}
run: npm install --no-save --force eslint@${{ matrix.eslint }}

Expand Down
Loading