Fix logic bug in find_hosts caching #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single = resulted in the value being assigned. If it's non-nil then it will also be true, even though the code suggests it was intended as a condition. In f87a1a8 it was changed, but it looks like that may have been accidental. Fixes: f87a1a8 ("Fixes #21025 - support for non-default dns and network views.")
timdeluxe
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
@ekohl Are you going to release it? Or shall i?
Just for your general information (sorry to misuse this): Most probably we are going rid of Infoblox in our company. This means, that i will not be able to test developments or releases anymore in the near future. Does it make sense to still be maintainer of the two Infoblox plugins?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single
=resulted in the value being assigned. If it's non-nil then it will also be true, even though the code suggests it was intended as a condition. In f87a1a8 it was changed, but it looks like that may have been accidental.Fixes: f87a1a8 ("Fixes #21025 - support for non-default dns and network views.")