Adjust for S7 in ggplot2 #429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
May 20, 2025
R/plot_patchwork.R
Outdated
Comment on lines
118
to
133
| `$.patchwork` <- function(x, i) { | ||
| if (i == "patches") { | ||
| attr(x, "patches") | ||
| } else { | ||
| NextMethod() | ||
| } | ||
| } | ||
| #' @export | ||
| `$<-.patchwork` <- function(x, i, value) { | ||
| if (i == "patches") { | ||
| attr(x, "patches") <- value | ||
| x | ||
| } else { | ||
| NextMethod() | ||
| } | ||
| } |
There was a problem hiding this comment.
This is absolutely lazyness on my part, because I wasn't keen on finding every instance of where the patches object is accessed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
This PR accompanies tidyverse/ggplot2#6364. It should be compatible with 3.5.2 as well as the linked PR. Briefly, it does two things:
patchesfield is implemented as attribute rather than a list-item, to not mess with S7 object properties and such.