Code

Reimplement classes in S7#6364

Code

Open

teunbrand wants to merge 88 commits intotidyverse:maintidyverse/ggplot2:mainfrom

teunbrand:S7_objectsteunbrand/ggplot2:S7_objectsCopy head branch name to clipboard

Commits

Commits on Mar 4, 2025

• add S7 as import

  teunbrand

  committed
  8bd9f31

  Copy full SHA for 8bd9f31

Commits on Mar 5, 2025

• custom properties for theme elements

  teunbrand

  committed
  d54e464

  Copy full SHA for d54e464

• convert theme elements to S7 classes

  teunbrand

  committed
  91302e0

  Copy full SHA for 91302e0

• adapt element definitions

  teunbrand

  committed
  8c199a1

  Copy full SHA for 8c199a1

• convert element_grob to S7 generic

  teunbrand

  committed
  202b80d

  Copy full SHA for 202b80d

Commits on Mar 6, 2025

• replace merge_element by S7

  teunbrand

  committed
  df02b37

  Copy full SHA for df02b37

• implement `$.element` for backward compatibility

  teunbrand

  committed
  b038e8f

  Copy full SHA for b038e8f

• Use S7 properties

  teunbrand

  committed
  09eef8d

  Copy full SHA for 09eef8d

• fix `inherits()` issues

  teunbrand

  committed
  62d8db4

  Copy full SHA for 62d8db4

• fix misc issues

  teunbrand

  committed
  27cdb73

  Copy full SHA for 27cdb73

• Revert "implement `$.element` for backward compatibility"

  Show description for 3bc0d63
  teunbrand

  committed
  3bc0d63

  Copy full SHA for 3bc0d63

• don't rely on `element$prop`

  teunbrand

  committed
  360c975

  Copy full SHA for 360c975

Commits on Mar 7, 2025

• move element properties

  teunbrand

  committed
  68fe80b

  Copy full SHA for 68fe80b

• convert `margin` to S7

  teunbrand

  committed
  8c3471e

  Copy full SHA for 8c3471e

• I liked index properties as an idea but apparently they print badly

  teunbrand

  committed
  9f69323

  Copy full SHA for 9f69323

• adapt failing example

  teunbrand

  committed
  e4b870b

  Copy full SHA for e4b870b

Commits on Mar 10, 2025

• import S7

  teunbrand

  committed
  0154671

  Copy full SHA for 0154671

• convert theme to S7

  teunbrand

  committed
  b4163e0

  Copy full SHA for b4163e0

• Reimplement S3 <uneval> into S7 <mapping>

  teunbrand

  committed
  7fce100

  Copy full SHA for 7fce100

Commits on Mar 11, 2025

• convert labels to S7

  teunbrand

  committed
  32ccdb2

  Copy full SHA for 32ccdb2

Commits on Mar 12, 2025

• make S7 class_ggplot

  teunbrand

  committed
  032ca6a

  Copy full SHA for 032ca6a

Commits on Mar 13, 2025

• Use `@` as accessor

  teunbrand

  committed
  c37317b

  Copy full SHA for c37317b

• double dispatch for `ggplot_add()`

  teunbrand

  committed
  90d644f

  Copy full SHA for 90d644f

• Write methods for external generics as S7

  teunbrand

  committed
  0310be8

  Copy full SHA for 0310be8

• backward compatibility for ggplot class

  teunbrand

  committed
  2607597

  Copy full SHA for 2607597

Commits on Mar 14, 2025

• Implement <ggplot_built> as S7

  teunbrand

  committed
  30b1118

  Copy full SHA for 30b1118

• implement `as.gtable` methods

  teunbrand

  committed
  ef5db54

  Copy full SHA for ef5db54

• rename mapping to class_mapping

  teunbrand

  committed
  206c394

  Copy full SHA for 206c394

• refine class_ggplot_built and related functions

  teunbrand

  committed
  53504c3

  Copy full SHA for 53504c3

• also access ggplot_built slots with normal extractors

  teunbrand

  committed
  bbdc7a5

  Copy full SHA for bbdc7a5

• resolve gnarlyness in S3/S7 method conflicts

  teunbrand

  committed
  2f06dd5

  Copy full SHA for 2f06dd5

Commits on Mar 17, 2025

• fix esoteric 'promise already under evaluation' error

  teunbrand

  committed
  39765cd

  Copy full SHA for 39765cd

• fix series of minor issues

  teunbrand

  committed
  07ebce6

  Copy full SHA for 07ebce6

• export theme as class

  teunbrand

  committed
  fece790

  Copy full SHA for fece790

• export labels class

  teunbrand

  committed
  f8ed252

  Copy full SHA for f8ed252

• collect classes in one place

  teunbrand

  committed
  8fde6e8

  Copy full SHA for 8fde6e8

• revert @include decisions

  teunbrand

  committed
  5453b28

  Copy full SHA for 5453b28

• Make S7 generic of `get_alt_text()`

  teunbrand

  committed
  9736300

  Copy full SHA for 9736300

• backport `@`

  teunbrand

  committed
  028068f

  Copy full SHA for 028068f

• exempt classes from pkgdown

  teunbrand

  committed
  c754551

  Copy full SHA for c754551

• lol at my incompetence

  teunbrand

  committed
  9acc1ee

  Copy full SHA for 9acc1ee

Commits on Mar 28, 2025

• resolve merge conflict

  Show description for edda7e4
  teunbrand

  committed
  edda7e4

  Copy full SHA for edda7e4

Commits on Mar 31, 2025

• allow variant error messages

  teunbrand

  committed
  5d41f0e

  Copy full SHA for 5d41f0e

• workaround for old R versions

  teunbrand

  committed
  77cb52d

  Copy full SHA for 77cb52d

• update pkgdown index

  teunbrand

  committed
  8177f06

  Copy full SHA for 8177f06

Commits on Apr 1, 2025

• resolve merge conflict

  Show description for 4f8a351
  teunbrand

  committed
  4f8a351

  Copy full SHA for 4f8a351

• backport `@`

  teunbrand

  committed
  b2f143e

  Copy full SHA for b2f143e

Commits on Apr 16, 2025

• resolve merge conflict

  Show description for 4fbf5cf
  teunbrand

  committed
  4fbf5cf

  Copy full SHA for 4fbf5cf

• S7-aware `is_theme_element()`

  teunbrand

  committed
  98fb83e

  Copy full SHA for 98fb83e

• utility for grabbing props

  teunbrand

  committed
  f56a504

  Copy full SHA for f56a504

• use classic extractors and subassignment

  teunbrand

  committed
  a775635

  Copy full SHA for a775635

• fallback for `register_theme_elements()`

  teunbrand

  committed
  b38f3e5

  Copy full SHA for b38f3e5

• contingencies for `inherits(x, <S7>)` on old R versions

  teunbrand

  committed
  aa14c88

  Copy full SHA for aa14c88

• resolve merge conflict

  Show description for c8a0683
  teunbrand

  committed
  c8a0683

  Copy full SHA for c8a0683

• use `is_theme()`

  teunbrand

  committed
  69ae934

  Copy full SHA for 69ae934

• sprinkle notes

  teunbrand

  committed
  67dae2d

  Copy full SHA for 67dae2d

Commits on May 14, 2025

• bump staged deprecations

  teunbrand

  committed
  fcfdc69

  Copy full SHA for fcfdc69

• add linejoins

  teunbrand

  committed
  924b8b6

  Copy full SHA for 924b8b6

• resolve merge conflict

  Show description for 764a2ce
  teunbrand

  committed
  764a2ce

  Copy full SHA for 764a2ce

• Disable `ggtext::element_markdown()` example

  teunbrand

  committed
  6eb2264

  Copy full SHA for 6eb2264

• fix failing tests

  teunbrand

  committed
  7595556

  Copy full SHA for 7595556

• resolve merge conflict

  Show description for 38ae287
  teunbrand

  committed
  38ae287

  Copy full SHA for 38ae287

• redocument

  teunbrand

  committed
  5797664

  Copy full SHA for 5797664

• resolve merge conflict

  Show description for 18b9273
  teunbrand

  committed
  18b9273

  Copy full SHA for 18b9273

• fix doc links

  teunbrand

  committed
  4b7a189

  Copy full SHA for 4b7a189

• Merge pull request #16 from teunbrand/S7_elements

  Show description for 8b285a5
  teunbrand

  authored
  8b285a5

  Copy full SHA for 8b285a5

• soft-deprecate `%+%`

  teunbrand

  committed
  0fc9a62

  Copy full SHA for 0fc9a62

• simplify logic block

  teunbrand

  committed
  8cf5d1e

  Copy full SHA for 8cf5d1e

• don't evaluate code temporarily in FAQ example

  teunbrand

  committed
  187e09c

  Copy full SHA for 187e09c

Commits on May 19, 2025

• run revdepcheck

  thomasp85

  committed
  027b074

  Copy full SHA for 027b074

Commits on May 20, 2025

• recover from S3 mappings

  teunbrand

  committed
  47557c8

  Copy full SHA for 47557c8

• enable classic subsetting for ggplot_built

  teunbrand

  committed
  c843860

  Copy full SHA for c843860

• resolve merge conflict

  Show description for b91bb9c
  teunbrand

  committed
  b91bb9c

  Copy full SHA for b91bb9c

• fix typo

  teunbrand

  committed
  0ef6d29

  Copy full SHA for 0ef6d29

Commits on May 21, 2025

• prevent NSE shenannigans

  teunbrand

  committed
  95cc8e5

  Copy full SHA for 95cc8e5

• avoid `%+%` in test code

  teunbrand

  committed
  a7dab26

  Copy full SHA for a7dab26

• add 'meta' property to track arbitrary fields

  teunbrand

  committed
  a03d41b

  Copy full SHA for a03d41b

• document new property

  teunbrand

  committed
  6ecf39e

  Copy full SHA for 6ecf39e

Commits on May 23, 2025

• resolve merge conflict

  Show description for 471a7e8
  teunbrand

  committed
  471a7e8

  Copy full SHA for 471a7e8

• fix stretchy guide bug

  teunbrand

  committed
  a315d8f

  Copy full SHA for a315d8f

• backward compatibility for `ggplot_add()`

  teunbrand

  committed
  32fa918

  Copy full SHA for 32fa918

• backward compatibility for `ggplot_add()`

  teunbrand

  committed
  f51324c

  Copy full SHA for f51324c

• notes for the future

  teunbrand

  committed
  ff12f37

  Copy full SHA for ff12f37

• backward compatibility for `ggplot_gtable()`

  teunbrand

  committed
  afadca1

  Copy full SHA for afadca1

• backwards compatibility for `element_grob()`

  teunbrand

  committed
  896666d

  Copy full SHA for 896666d

Commits on May 26, 2025

• keep theme class

  teunbrand

  committed
  3755e2d

  Copy full SHA for 3755e2d

• Merge branch 'main' into S7_objects

  teunbrand

  committed
  6660ca4

  Copy full SHA for 6660ca4

• add news bullet

  teunbrand

  committed
  3e3b155

  Copy full SHA for 3e3b155