Refactor(optimizer)!: remove recursion from simplify
#4988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
changed the title
georgesittas
force-pushed
the
jo/make_simplify_iterative
branch
from
cc5dba8 to
d480c8e
Compare
georgesittas
commented
Apr 17, 2025
tobymao
reviewed
Apr 17, 2025
georgesittas
commented
Apr 17, 2025
georgesittas
force-pushed
the
jo/make_simplify_iterative
branch
2 times, most recently
from
f783593 to
e01a0ba
Compare
tobymao
approved these changes
Apr 17, 2025
VaggelisD
reviewed
Apr 18, 2025
georgesittas
force-pushed
the
jo/make_simplify_iterative
branch
from
e01a0ba to
f08f3f7
Compare
VaggelisD
approved these changes
Apr 21, 2025
|
Just a heads up: I don't think this PR will enable us to handle large ASTs without making the I've created two branches, trying different approaches to achieve this, but both incur a performance hit compared to main and so still need to figure out how to optimize them further to at least reach parity.
EDIT: I ended up refactoring |
georgesittas
commented
Apr 21, 2025
georgesittas
force-pushed
the
jo/make_simplify_iterative
branch
from
80c727c to
38ec768
Compare
tobymao
approved these changes
Apr 21, 2025
georgesittas
changed the title
georgesittas
changed the title
simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw main...toby/simplify yesterday and figured I'd try to take it to the finish line. Please take a look.