👌 Reset directive option specs at start of build #1448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem, that the
option_spec
attributes are modified on a class level for:NeedDirective
NeedextendDirective
NeedserviceDirective
and thus remain changed for subsequent sphinx runs in the same interpreter session.
The problem was a finding of #1441.
This is particularly of issue for SN test cases, which all run in the same Python interpreter,
and should ideally be reproducible, independent of any preceding tests run.
The PR defines a
reset_options_spec
class method for modified directives,to revert the runtime changes during the
config-inited
event.