Skip to content

Rolldown-Vite #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 141 commits into
base: main
Choose a base branch
from
Draft

Rolldown-Vite #84

wants to merge 141 commits into from

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 7, 2025

Description

Current Status

Intended behavior differences

Known missing features

related to native plugins
TODO list for me
  • set rolldown's minify target
  • update docs

Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/vitejs/rolldown-vite@84

commit: c22ffbc

@sapphi-red sapphi-red force-pushed the rolldown-vite branch 2 times, most recently from 9ce2683 to a974a4a Compare March 17, 2025 03:57
@sapphi-red sapphi-red changed the title WIP Rolldown-Vite Mar 17, 2025
@sapphi-red sapphi-red mentioned this pull request Mar 17, 2025
3 tasks
`function(dep, importerUrl) { return new URL(dep, importerUrl).href }`
: // If the base isn't relative, then the deps are relative to the projects `outDir` and the base
// is appended inside __vitePreload too.
`function(dep) { return ${JSON.stringify(environment.config.base)}+dep }`

Check warning

Code scanning / CodeQL

Improper code sanitization

Code construction depends on an [improperly sanitized value](1).
@christianjuth
Copy link

christianjuth commented Mar 25, 2025

Found this PR in the Vite docs. Curious how stable rolldown-vite is. On a scale of "Next.js would call this is stable" to "this will actually work 99% of the time", were are we at?

@sapphi-red sapphi-red force-pushed the rolldown-vite branch 2 times, most recently from 51fd297 to 3fc2ac5 Compare March 26, 2025 02:29
@sapphi-red
Copy link
Member Author

Found this PR in the Vite docs. Curious how stable rolldown-vite is. On a scale of "Next.js would call this is stable" to "this will actually work 99% of the time", were are we at?

I'd say it would work for basic cases as it is passing most tests through out the ecosystem.

sapphi-red and others added 17 commits March 26, 2025 14:58
Co-authored-by: underfin <likui.underfin@gmail.com>
Co-authored-by: underfin <likui.underfin@gmail.com>
Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
Co-authored-by: Yury <YurySolovyov@users.noreply.github.com>
Co-authored-by: underfin <2218301630@qq.com>
Co-authored-by: IWANABETHATGUY <iwanabethatguy@qq.com>
Co-authored-by: IWANABETHATGUY <iwanabethatguy@qq.com>
Co-authored-by: IWANABETHATGUY <iwanabethatguy@qq.com>
Co-Authored-By: Evan You <evan@vuejs.org>
@niksy
Copy link

niksy commented May 19, 2025

define: per-environment config is not supported yet

Is there an open issue for this?

@sapphi-red
Copy link
Member Author

define: per-environment config is not supported yet

Is there an open issue for this?

No, there isn't. But checking the code, actually it should work. Feel free to create one if it's not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants