Skip to content

makes extracor type idempotent in version 4+ #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

witjoh
Copy link
Contributor

@witjoh witjoh commented May 22, 2023

Following attributes keep on changing in puppet 7 and graylog version 4.

  • type (seems its renamed from extractor_type to just type in the api)
  • cut or copy, forcing it to be a symbol instead of a string here (ruby version thing ?)
  • converters, puppet makes an empty one an array, but it needs to be an hash

Haven't tested this code with version 3.

Still not interestes in upgrading your graylog to a higher version ? If not, maybe I can go for a puppet_graylog_api_ng module for the 5+ versions of graylog ? Or having separate branches in this one ?

@philomory
Copy link
Contributor

Following attributes keep on changing in puppet 7 and graylog version 4.

  • type (seems its renamed from extractor_type to just type in the api)
  • cut or copy, forcing it to be a symbol instead of a string here (ruby version thing ?)
  • converters, puppet makes an empty one an array, but it needs to be an hash

Haven't tested this code with version 3.

Still not interestes in upgrading your graylog to a higher version ? If not, maybe I can go for a puppet_graylog_api_ng module for the 5+ versions of graylog ? Or having separate branches in this one ?

Sorry for the delay in responses to other, related issues. We're migrating away from Graylog entirely, and will not be able to maintain this module any farther as we have no further use for it. My plan at this point is to donate it to Vox Pupuli (aka Puppet Community), if they're interested in having it (although I have not yet begun the process for initiating the transfer).

If you're interested in maintaining it yourself, that would also be an option.

@witjoh
Copy link
Contributor Author

witjoh commented May 23, 2023

transfering it to vox-pupuli should be indeed the best option.

If they are not interested, I can probably take over.

In the meantime, I will just use my fork and see what happens in the future.

Still thinking to adapt this module for the latest versions of graylog, supporting probably mainly version 5 (and maybe keep it compatible with version 4)

just give a shout when needed :)

@philomory
Copy link
Contributor

@witjoh Word from Vox Pupuli is that they'd be happy to adopt the module, but, they'd be happier if someone actually volunteered to help maintain the module with them. That discussion is happening in the Puppet Community slack's #voxpupuli; you can review the relevant thread here if you're interested: https://puppetcommunity.slack.com/archives/C0W1Y5VL0/p1685043628326209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants