fix(TimePicker): #7267 #7414
Closed
fix(TimePicker): #7267 #7414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjinzhou
requested changes
Apr 19, 2024
| const mergedHour = Math.max(0, newHour); | ||
| const mergedMinute = Math.max(0, newMinute); | ||
| const mergedSecond = Math.max(0, newSecond); | ||
| const mergedHour = newHour < 0 ? minutes.value.find(hour => !hour.disabled).value : newHour; |
There was a problem hiding this comment.
这里应该是 hour find 吧
另外如果find 不到怎么处理呢
There was a problem hiding this comment.
是的，应该是hours.find。在find不到时，仍然取默认的newHour，newMinute，newSecond如何呢？
aShu-guo
force-pushed
the
fix/TimePicker-disabled
branch
from
3333e6e to
fde90a9
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
初次选中时未检查disabled状态，而是默认选中第一个