Add Wrapper Package with a Couple of Existing Examples #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-baines
reviewed
Jun 4, 2025
| // Of course it will not work in every case but that is not the point. | ||
| func SimpleVersionCheck(conf *config.Config, rePattern string, versionConstraint string) exploit.VersionCheckType { | ||
| url := protocol.GenerateURL(conf.Rhost, conf.Rport, conf.SSL, "/") | ||
| resp, body, ok := protocol.HTTPGetCache(url) |
There was a problem hiding this comment.
formatting gone wrong here and elsewhere in the file
terrorbyte
reviewed
Jun 4, 2025
|
|
||
| // This removes generic version checking boiler plate that works in a great deal of cases. | ||
| // Of course it will not work in every case but that is not the point. | ||
| func SimpleVersionCheck(conf *config.Config, rePattern string, versionConstraint string, endpoint string) exploit.VersionCheckType { |
There was a problem hiding this comment.
We should move this to the same as CheckSemVer in go-exploit
| // to avoid certain import cycle errors. | ||
|
|
||
| // Helper function for use within exploits to reduce the overall amount of boilerplate when setting up a file server to host a dynamically generated file. | ||
| func HTTPServeFileInitAndRunWithFile(conf *config.Config, fileName string, routeName string, data[]byte) bool { |
There was a problem hiding this comment.
idk where to put this but this probably shouldn't be wrappers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #377
The goal is to put helper functions/wrappers in this package to reduce boilerplate and increase consistency. Also helps to prevent import cycle issues.
Usage examples:
Simple Version Check
Open to opinions about whether or not to include additional params such as status code to check for or passing the endpoint as a param.
Dynamic File Serve: