Skip to content

refactor(css): Remove unnecessary and structure code, add comments #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Jun 13, 2023

Related issue (if exists)

#3449

Summary

🤖 Generated by Copilot at 86f789c

Improved the CSS plugin for rspack and updated the test case for data imports. The plugin can now generate the CSS source for a chunk of modules, and the test case uses a snapshot to verify the output.

Walkthrough

🤖 Generated by Copilot at 86f789c

  • Refactor CSS plugin logic and update data imports test case
  • Add render_chunk_to_source method to CssPlugin to generate CSS source for a chunk (link)
  • Use render_chunk_to_source method and simplify render_manifest hook logic (link, link)
  • Update imports to include Chunk and ModuleIdentifier types and remove unused type (link)
  • Use snapshot for expected CSS content in data-imports test case (packages/rspack/tests/cases/schemes/data-imports/index.js, link)

@hyf0 hyf0 requested review from hardfist and ahabhgk as code owners June 13, 2023 04:36
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jun 13, 2023
ahabhgk
ahabhgk previously approved these changes Jun 13, 2023
@hyf0 hyf0 enabled auto-merge June 13, 2023 04:45
@hyf0 hyf0 added this pull request to the merge queue Jun 13, 2023
Merged via the queue into main with commit ce95372 Jun 13, 2023
@hyf0 hyf0 deleted the hyf_234892938402 branch June 13, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants