chore: remove unused packages #829
Conversation
🦋 Changeset detectedLatest commit: c38bd74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alcpereira
force-pushed
the
chore/remove-unused-packages
branch
from
4bf110c to
c38bd74
Compare
|
(On my phone now) But as far as I recall the sirv-cli is used for starting the server in from the CLI |
| @@ -31,7 +31,6 @@ | |||
| "dependencies": { | |||
| "@inquirer/prompts": "^7.3.2", | |||
| "ora": "^8.2.0", | |||
| "sirv-cli": "^3.0.0", | |||
There was a problem hiding this comment.
It's used here, not sure if you have a better way to do this, but for now I believe this packages still needs to be in the deps
There was a problem hiding this comment.
npx should install the package, but I will investigate it a bit further.
In theory npx my-package should download the my-package and also its dependency.
In the code you linked we are calling npx sirv which is for sirv package, but it does not have sirv-cli as a dependency (here).
So it should not have any impact, but I will double check.
There was a problem hiding this comment.
As far as I remember sirv is the command and npx is also used to run the server if it's already installed
fs-extraandsirv-cliseems to be unused dependencies that we can remove