-
Notifications
You must be signed in to change notification settings - Fork 307
Add definition for composed selection range #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dizhang168
wants to merge
15
commits into
whatwg:main
Choose a base branch
from
dizhang168:composed-live-range
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7c48fa5
Add definition for composed live range
dizhang168 487cac0
Review, format changes
dizhang168 461aed7
Fix collapse logic for set the start or end
dizhang168 413348d
Fix for= typo
dizhang168 c7f38b1
Linking nit
domfarolino 1f74a51
Remove em dash to fix spacing in rendered spec
domfarolino f5b6935
Review changes: rename composed live range, improve format of set the…
dizhang168 367288b
define composed selection range separately from live range
dizhang168 fe020ca
Update composed selection range definition
dizhang168 4760e78
Change to compare with shadow-including root instead of document node
dizhang168 d8ca5a5
legacy uncomposed range + format
dizhang168 99b212b
Merge remote-tracking branch 'upstream/main' into composed-live-range
dizhang168 700ca5e
Add composed position definition, rewrite set the start/end
dizhang168 1cf2b12
fix typo
dizhang168 59d9595
Name is composed range + improve spec language
dizhang168 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.