-
Notifications
You must be signed in to change notification settings - Fork 537
Fixes Ogl when resizing and dragging shapes #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[Float issues] [(s)]
[ * Attachment points are computed as float ] [wxWidgets#2739]
[ * Don't use RealPoint * Do integer arithmetic ] [(s)]
Want to get these set of changes into a daily build. If I need more patches I can work against it. I verified these changes by modifying the virtual environment I created. |
Can you either edit the title or explain what that markup in the commit message and the PR title means? |
I hope the above is clearer. Please advise |
Couple things for the reviewers to watch for:
|
Hmm |
This pull request has been mentioned on Discuss wxPython. There might be relevant details there: |
[
Many of the computations when resizing or moving OGL shapes result in float values. The result is that the
wx.DC
primitive calls fail because they expect integer values. This PR changes the computations results to become integer values, thus method calls on the wx device contexts do not failMost of the changes involve
//
' instead of the float operator '/
'wx.RealPoint
to justwx.Point
float
constants to integer constants]
Fixes #2739