Skip to content

Executable coding blocks production-readiness - PR 3 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tahachm
Copy link
Collaborator

@tahachm tahachm commented Mar 8, 2025

Note: This is a stacked PR based off the earlier 'Executable coding blocks production-readiness - PR 2'.

In this PR, I processed 44 questions, of which the code blocks for 21 questions were adjusted. The remaining required DOM or had async code blocks that were left non-executable.

Common changes:

  • Added console.log statements to allow learners to correlate the code outcomes by running the cell
  • fixed undefined and miss property errors
  • Enhanced clarity in examples. I vetted the examples and improved / changed some code blocks

Major issues encountered:

  • async code and examples requiring a DOM
  • potential issue with how 'this' is handled in the executable code blocks. Will discuss.

@tahachm tahachm requested a review from yangshun March 8, 2025 16:15
@tahachm tahachm self-assigned this Mar 8, 2025
@yangshun yangshun merged commit 16265c7 into taha/executable-coding-blocks-2 Mar 9, 2025
@yangshun yangshun deleted the taha/executable-coding-blocks-3 branch March 9, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants