[NBS] Open different YDB graphs depending on the channel kind #3540

Georg-0001 · 2025-05-20T04:17:28Z

This request solves point 4 from [NBS] monitoring pages issues #3504.

Now, Graphs button leads to different pages depending on Channel type.
For all types of channel a histograms with handle classes: GetFast and PutUserData is constructed.

For Log type additionally constructed histogram with handle class: PutTabletLog.

For Merged and Mixed types additionally constructed histograms with handle classes:
GetAsync and PutAsyncBlob.

github-actions · 2025-05-20T04:17:37Z

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

Georg-0001 · 2025-05-20T04:54:36Z

Извиняюсь, не увидел комментарии по предыдущему pull request
(не включил git config core.hooksPath.githooks и снова лишний файл settings.json)

Georg-0001 · 2025-05-20T09:33:28Z

убрал settings.json

…-button-Monitoring-pages-issues-3504

cloud/blockstore/libs/diagnostics/hostname.cpp

github-actions · 2025-05-21T06:22:18Z

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 291ed19.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4942	4941	0	1	0	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 291ed19.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4942	4941	0	1	0	0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 291ed19.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4942	4941	0	1	0	0

komarevtsev-d · 2025-05-21T10:37:19Z

cloud/blockstore/libs/diagnostics/hostname.cpp

+        R"(", host="*", service="vdisks", subsystem="latency_histo", handleclass="PutTabletLog"})&q.2.name=C)";
+    constexpr TStringBuf GetAsync =
+        R"(q.2.s=histogram_percentile(100, {project="kikimr", cluster="*", storagePool="%s", group="%)" PRIu32
+        R"(", host="*", service="vdisks", subsystem="latency_histo", handleclass="GetAsync"})&q.2.name=C)";


komarevtsev-d · 2025-05-21T10:37:25Z

cloud/blockstore/libs/diagnostics/hostname.cpp

+        R"(", host="*", service="vdisks", subsystem="latency_histo", handleclass="GetAsync"})&q.2.name=C)";
+    constexpr TStringBuf PutAsyncBlob =
+        R"(q.3.s=histogram_percentile(100, {project="kikimr", cluster="*", storagePool="%s", group="%)" PRIu32
+        R"(", host="*", service="vdisks", subsystem="latency_histo", handleclass="PutAsyncBlob"})&q.3.name=D)";


komarevtsev-d · 2025-05-21T10:48:57Z

cloud/blockstore/libs/diagnostics/hostname.cpp

@@ -118,23 +118,54 @@ TString GetMonitoringNBSOverviewToTVUrl(const TDiagnosticsConfig& config)
 TString GetMonitoringYDBGroupUrl(
    const TDiagnosticsConfig& config,
    ui32 groupId,
-    const TString& storagePool)
+    const TString& storagePool,
+    const TString& dataKind)
 {
    constexpr TStringBuf GetFast =
        R"(q.0.s=histogram_percentile(100, {project="kikimr", cluster="*", storagePool="%s", group="%)" PRIu32
        R"(", host="*", service="vdisks", subsystem="latency_histo", handleclass="GetFast"})&q.0.name=A)";


Внутри всех этих строк повторяется весь текст, кроме handleclass.
Давай сделаем один шаблон, а в него будем подставлять нужный handleclass.

Предлагаю сделать функцию, которая принимает строку dataKind (например "Mixed"), а возвращает уже нужную строку с queries.
Внутри функции у тебя один шаблон

constexpr TStringBuf GetFast = R"(q.0.s=histogram_percentile(100, {project="kikimr", cluster="*", storagePool="%s", group="%)" PRIu32 R"(", host="*", service="vdisks", subsystem="latency_histo", handleclass="%s"})&q.0.name=%s)";

Ты его заполняешь через Sprintf и добавляешь у результату.
Только учти что name должен быть везде разные, но это не должно стать проблемой.

Для каждого dataKind сделай constexpr array тех handleclass которые ты хочешь видеть

komarevtsev-d

поправить

github-actions · 2025-05-21T12:38:28Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 8ee1c58.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
5359	5359	0	0	0	0

github-actions · 2025-05-23T14:01:32Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a5cae67.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
5359	5359	0	0	0	0

komarevtsev-d · 2025-05-23T12:00:27Z

cloud/blockstore/libs/diagnostics/hostname.cpp

+    constexpr std::array<TStringBuf, 4> MergedAndMixedHandleclasses(
+        {"GetFast", "PutUserData", "GetAsync", "PutAsyncBlob"});
+
+    constexpr std::array<TStringBuf, 4> QueryNames({"A", "B", "C", "D"});


Можно просто на месте

char queryName = 'A'; ++queryName;

komarevtsev-d · 2025-05-27T10:21:48Z

cloud/blockstore/libs/diagnostics/hostname.cpp

+    constexpr std::array<TStringBuf, 3> LogHandleclasses(
+        {"GetFast", "PutUserData", "PutTabletLog"});
+    constexpr std::array<TStringBuf, 4> MergedAndMixedHandleclasses(
+        {"GetFast", "PutUserData", "GetAsync", "PutAsyncBlob"});


Функция в анонимном namespace

[[nodiscard]] std::span<const TStringBuf> GetHandleClasses(const TString& dataKind) { constexpr std::array<TStringBuf, 2> DefaultHandleclasses( {"GetFast", "PutUserData"}); constexpr std::array<TStringBuf, 3> LogHandleclasses( {"GetFast", "PutUserData", "PutTabletLog"}); constexpr std::array<TStringBuf, 4> MergedAndMixedHandleclasses( {"GetFast", "PutUserData", "GetAsync", "PutAsyncBlob"}); if (dataKind == "Log") { return LogHandleclasses; } else if (dataKind == "Merged" || dataKind == "Mixed") { return MergedAndMixedHandleclasses; } return DefaultHandleclasses; }

А дальше у тебя один цикл вместо N циклов

github-actions · 2025-05-28T09:39:53Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 382b61b.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
5359	5359	0	0	0	0

komarevtsev-d · 2025-05-28T11:59:50Z

cloud/blockstore/libs/diagnostics/hostname.cpp

@@ -5,13 +5,22 @@
 #include <util/generic/string.h>
 #include <util/string/builder.h>
 #include <util/system/hostname.h>
+#include <array>
+#include <span>


clang-format

komarevtsev-d · 2025-05-28T12:00:33Z

cloud/blockstore/libs/diagnostics/hostname.cpp

+constexpr std::array<const char*, 3> LogHandleClasses(
+    {"GetFast", "PutUserData", "PutTabletLog"});
+constexpr std::array<const char*, 4> MergedAndMixedHandleClasses(
+    {"GetFast", "PutUserData", "GetAsync", "PutAsyncBlob"});


Они в одной функции же только используются? Можно было прям там внутри и оставить

Там мы из функции возвращаем std::span, поэтому если внтури функции их объявить, то
указатель на строку протухнет и будет ошибка (вначале сделал так и не работало).

komarevtsev-d · 2025-05-28T12:00:51Z

cloud/blockstore/libs/diagnostics/hostname.cpp

+    {"GetFast", "PutUserData"});
+constexpr std::array<const char*, 3> LogHandleClasses(
+    {"GetFast", "PutUserData", "PutTabletLog"});
+constexpr std::array<const char*, 4> MergedAndMixedHandleClasses(


А куда TStringBuf подевался?

komarevtsev-d · 2025-05-28T12:01:37Z

cloud/blockstore/libs/diagnostics/hostname.cpp

+        ++queryName;
+    }
+
+    return queries.c_str();


return queries;

komarevtsev-d · 2025-05-28T12:13:59Z

cloud/blockstore/libs/storage/partition/part_actor_monitoring.cpp

@@ -77,11 +77,15 @@ void DumpDownGroups(
                            for (const TTabletChannelInfo& channelInfo:
                                 matchedInfos)
                            {
+                                TString dataKind = TStringBuilder()


Давай по всему ПРу переименуем channelDataKind в channelKind

А зачем ты тут преобразуешь в строку, если можно использовать EChannelDataKind? И возможность switch написать появится

github-actions · 2025-05-29T13:33:06Z

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 2a14694.

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
5359	5359	0	0	0	0

[NBS] monitoring pages issues ydb-platform#3504 update Graphs button

291ed19

Georg-0001 force-pushed the Graph-button-Monitoring-pages-issues-3504 branch from f4863a6 to 291ed19 Compare May 20, 2025 09:32

Merge branch 'main' of https://github.com/ydb-platform/nbs into Graph…

19b13d6

…-button-Monitoring-pages-issues-3504

komarevtsev-d self-requested a review May 21, 2025 05:29

komarevtsev-d added ok-to-test Label to approve test launch for external members blockstore Add this label to run only cloud/blockstore build and tests on PR labels May 21, 2025

github-actions bot removed the ok-to-test Label to approve test launch for external members label May 21, 2025

komarevtsev-d reviewed May 21, 2025

View reviewed changes

cloud/blockstore/libs/diagnostics/hostname.cpp Outdated Show resolved Hide resolved

cloud/blockstore/libs/diagnostics/hostname.cpp Outdated Show resolved Hide resolved

cloud/blockstore/libs/diagnostics/hostname.cpp Outdated Show resolved Hide resolved

fix remarks

8ee1c58

komarevtsev-d added large-tests Launch large tests for PR ok-to-test Label to approve test launch for external members labels May 21, 2025

github-actions bot removed the ok-to-test Label to approve test launch for external members label May 21, 2025

komarevtsev-d reviewed May 21, 2025

View reviewed changes

komarevtsev-d requested changes May 21, 2025

View reviewed changes

fix

a5cae67

komarevtsev-d added the ok-to-test Label to approve test launch for external members label May 23, 2025

github-actions bot removed the ok-to-test Label to approve test launch for external members label May 23, 2025

Georg-0001 requested a review from komarevtsev-d May 27, 2025 08:59

komarevtsev-d requested changes May 27, 2025

View reviewed changes

fix remarks

382b61b

Georg-0001 requested a review from komarevtsev-d May 28, 2025 07:34

komarevtsev-d requested changes May 28, 2025

View reviewed changes

fix

2a14694

Georg-0001 requested a review from komarevtsev-d May 29, 2025 11:15

komarevtsev-d changed the title ~~[NBS] monitoring pages issues #3504 (Updated Graphs button)~~ [NBS] Open different YDB graphs depending on the channel kind Jun 2, 2025

[NBS] Open different YDB graphs depending on the channel kind #3540

Are you sure you want to change the base?

[NBS] Open different YDB graphs depending on the channel kind #3540

Uh oh!

Conversation

Georg-0001 commented May 20, 2025

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

Georg-0001 commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Georg-0001 commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

komarevtsev-d left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

komarevtsev-d May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Georg-0001 May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

Uh oh!

Georg-0001 commented May 20, 2025 •

edited

Loading

github-actions bot commented May 21, 2025 •

edited

Loading

komarevtsev-d May 27, 2025 •

edited

Loading

Georg-0001 May 29, 2025 •

edited

Loading