issue-3371: skip reporting of ZeroBlocks metrics #3561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmyagkov
added
the
blockstore
antonmyagkov
force-pushed
the
users/myagkov/issue-3371-skip-zero-blocks-metrics
branch
from
442d460 to
d33274f
Compare
antonmyagkov
force-pushed
the
users/myagkov/issue-3371-skip-zero-blocks-metrics
branch
2 times, most recently
from
ae0e8cf to
db3fdfb
Compare
antonmyagkov
force-pushed
the
users/myagkov/issue-3371-skip-zero-blocks-metrics
branch
from
db3fdfb to
24ad088
Compare
debnatkh
reviewed
May 27, 2025
SvartMetal
changed the title
antonmyagkov
force-pushed
the
users/myagkov/issue-3371-skip-zero-blocks-metrics
branch
from
629b86f to
6a24f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip reporting zeroblocks metrics as write metrics when the discard option is enabled, as this can mislead clients into overestimating the actual disk throughput. I added ReportZeroBlocksMetricsForYDBBasedDisks field to diagnostics config to control this behavior.