-
Notifications
You must be signed in to change notification settings - Fork 28
365.add support of custom codecs in topics #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_v2.4.0
Are you sure you want to change the base?
365.add support of custom codecs in topics #447
Conversation
…-in-topics' into 365.Add-support-of-custom-codecs-in-topics # Conflicts: # topic/src/main/java/tech/ydb/topic/utils/Encoder.java # topic/src/main/java/tech/ydb/topic/write/impl/AsyncWriterImpl.java # topic/src/main/java/tech/ydb/topic/write/impl/SyncWriterImpl.java # topic/src/main/java/tech/ydb/topic/write/impl/WriterImpl.java # topic/src/test/java/tech/ydb/topic/impl/YdbTopicsCustomCodecIntegrationTest.java # topic/src/test/java/tech/ydb/topic/impl/YdbTopicsCustomCodecTest.java
…custom-codecs-in-topics # Conflicts: # topic/src/main/java/tech/ydb/topic/utils/Encoder.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release_v2.4.0 #447 +/- ##
====================================================
+ Coverage 58.75% 59.22% +0.47%
- Complexity 2171 2207 +36
====================================================
Files 320 323 +3
Lines 12938 12965 +27
Branches 1269 1271 +2
====================================================
+ Hits 7602 7679 +77
+ Misses 4720 4686 -34
+ Partials 616 600 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tests |
topic/src/main/java/tech/ydb/topic/description/CodecRegistry.java
Outdated
Show resolved
Hide resolved
@alex268
|
topic/src/main/java/tech/ydb/topic/description/CodecRegistry.java
Outdated
Show resolved
Hide resolved
Add tests for rewrite predefined codec. Remove ProtoUtils class
Finally after all discussion try to implement feature
#365
What major changes:
methods that can be used in backward compability mark as deprecated
(it's all syn/async reader/writer)
5.1 Test on custom codec + include test on all existed predefind codec
5.2 Test on register
5.3 Test on old deprecated methods
To use custom codec:
Summary
Seems next days try to pass all tests for all jdks