Skip to content

hypothesis: Don't generate node name: 'zarr.json' #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

hypothesis: Don't generate node name: 'zarr.json' #3020

merged 1 commit into from
Apr 25, 2025

Conversation

dcherian
Copy link
Contributor

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dcherian dcherian requested a review from d-v-b April 25, 2025 14:12
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 25, 2025
d-v-b
d-v-b approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, and we should later fix the behavior in zarr (i.e., by preventing users from creating keys name zarr.json, and other reserved names)

@d-v-b d-v-b enabled auto-merge (squash) April 25, 2025 14:14
@d-v-b d-v-b merged commit 0351c4e into zarr-developers:main Apr 25, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @d-v-b