Skip to content

markdown: Fix parse inline code display #30937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

markdown: Fix parse inline code display #30937

merged 3 commits into from
May 26, 2025

Conversation

CharlesChen0823
Copy link
Contributor

@CharlesChen0823 CharlesChen0823 commented May 19, 2025 •
edited
Loading

inline code startswith "`", "``", "```", should all valid. current implement only work with startswith "`".

Release Notes:

  • N/A

@notpeter notpeter added the cla-signed The user has signed the Contributor License Agreement label May 19, 2025
SomeoneToIgnore
SomeoneToIgnore reviewed May 26, 2025
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thank you for spotting.

There is a way to add a test on this to the collection below, isn't there?

@SomeoneToIgnore SomeoneToIgnore self-assigned this May 26, 2025
SomeoneToIgnore
SomeoneToIgnore approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.

@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) May 26, 2025 11:18
@SomeoneToIgnore SomeoneToIgnore merged commit 134463f into zed-industries:main May 26, 2025
19 checks passed
@CharlesChen0823 CharlesChen0823 deleted the fix_markdown_parse branch May 26, 2025 13:50
Daquisu pushed a commit to Daquisu/zed that referenced this pull request May 26, 2025
@CharlesChen0823 @Daquisu
markdown: Fix parse inline code display (zed-industries#30937)
73f4bb1 
inline code startswith "\`", "\`\`", "\`\`\`", should all valid. current
implement only work with startswith "\`".

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore approved these changes

Assignees

@SomeoneToIgnore SomeoneToIgnore

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlesChen0823 @SomeoneToIgnore @notpeter