Skip to content

fix: api group set timeout: 0s not working. #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SpectatorNan
Copy link
Contributor

@server(
timeout: 0s
group: upload
prefix: upload
maxBytes: 10485760
)

fix api group set timeout is zero, but engine use default timeout duration. cause api timeout is not the expected result

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (8690859) to head (be82bf4).
Report is 335 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
rest/engine.go 100.00% <100.00%> (ø)
rest/server.go 96.90% <100.00%> (+0.37%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevwan kevwan force-pushed the route-group-timeout branch from 7e76f0e to 58ca150 Compare April 17, 2025 15:07
@kevwan kevwan requested a review from Copilot April 17, 2025 15:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

@kevwan kevwan added bug area/api Categorizes issue or PR as related to API syntax or usages. labels May 2, 2025
@kevwan kevwan force-pushed the route-group-timeout branch from 58ca150 to be82bf4 Compare May 2, 2025 11:33
@kevwan kevwan self-assigned this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Categorizes issue or PR as related to API syntax or usages. bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants