home [nfc]: Clean up some dead safe-area code from before bottom-tabs #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The responsibility for consuming the bottom inset is now external to all of these *PageBody widgets; it's handled by Scaffold.bottomNavigationBar. So we don't need to forward a bottom-inset value down to descendants (via `SafeArea.bottom: false`), and we don't need to add widgets to pad the bottom inset; the bottom-inset height in all these places is zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The responsibility for consuming the bottom inset is now external to all of these *PageBody widgets; it's handled by
Scaffold.bottomNavigationBar. So we don't need to forward a bottom-inset value down to descendants
(via
SafeArea.bottom: false), and we don't need to add widgets to pad the bottom inset; the bottom-inset height in all these places is zero.