validate scale before converting to BigInt #3864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
approved these changes
Apr 6, 2023
cowtowncoder
reviewed
Apr 6, 2023
| */ | ||
| public BigInteger bigIntegerValue() { return BigInteger.ZERO; } | ||
| public BigInteger bigIntegerValue() throws StreamConstraintsException { return BigInteger.ZERO; } |
There was a problem hiding this comment.
Actually.... this is backwards-incompatible change, will need to wrap exception. Since I just merged I'll change this.
There was a problem hiding this comment.
Ok, decided to use "sneaky throw" instead. Not ideal but will (have to) do for now.
cowtowncoder
added a commit
that referenced
this pull request
Apr 6, 2023
|
Thank you for catching these cases @pjfanning ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3863