Implement #6413 : Data pages of newly gbak restored databases should marked as "swept" [CORE6164] #8549
Conversation
…marked as "swept" [CORE6164]
|
Why exception for system relations? |
There is no promise that system tables contains no backversions after restore. |
|
Vlad, thank you!!! |
Does this flag prevent garbage collection as well? System tables are read extremely intensively so hardly any garbage in them can left uncollected. |
Read the code.
Do you give guarantee ? Run gbak -r and gstat -r -s after it. |
| if (type == DPM_primary) | ||
| { | ||
| // When restoring, mark slot as swept, data page will be marked by our caller | ||
| if (tdbb->getAttachment()->isGbak() && !relation->isSystem()) |
There was a problem hiding this comment.
- I would put this check in a separate inline function like
inline bool sweptOnRestore(thread_db* tdbb, jrd_rel* rel). isGbak()is not 100% safe to use. I remember I tested a case where I created some DB trigger which inserts/updates data. And when I startedgbak -b, the normal swept flag logic wasn't working during execution of the trigger. So we need to distinguish between backup and restore.isRWGbak()is more suitable here but it's not going to work right away.ATT_creatoris also should be passed to parallel worker attachments. To do that, I createdisc_dpb_gbak_restore_rel_attachsoJProvider::internalAttachcan check it along withisc_dpb_gbak_attachand setATT_creator.
If it's needed, I can provide a patch with these corrections.
No description provided.