-
Notifications
You must be signed in to change notification settings - Fork 0
Set up a "Hello world" rails project #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
rails new hello-rails-back-end --api -d postgresql Setup Database: Add all rerquired dependencies to Gem file bundle install
rails db:create rails generate model Greeting message:string rails db:migrate rails db:seed
rails generate scaffold_controller api/v1/Greeting
Fix linters
Line 23 config.action_controller.perform_caching = true Line 24 config.action_controller.enable_fragment_cache_logging = true Line 60 config.assets.quiet = true
Line 17:config.action_controller.perform_caching = true Line 31: config.assets.compile = false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status: Approved 🟢 🟢 🟢
Hi @Lucash2022,
Good job working on the changes highlighted by the previous reviewer. 👍🏽
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉
Highlights:
✅ You used Gitflow correctly 👍🏽
✅ The Linter checks passed 👍🏽
✅ Rails and React apps work fine as expected 👍🏽
✅ The server renders random greetings 👍🏽
✅ Generates random greetings and are rendered on the Front-end 👍🏽
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this PR, I have:
Note: Front-end PR
Thanks for visiting 👍. If you have any questions feel free to ask 🙂