Skip to content

Set up a "Hello world" react project #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Lucas-Erkana
Copy link
Owner

@Lucas-Erkana Lucas-Erkana commented Jul 19, 2023

Hi Reviewer

In this PR I have:

  • Create a new React app called 'hello-react-front-end'
  • Initialize your project with Git.
  • Create the App component with react-router.
  • Create the Greeting component that will display a greeting. Set it up as a route in your App component.
  • Create a store, an action, and a reducer that will connect to you API endpoint to get the random greeting.
  • Display the random greeting in your Greeting component.

Note: Backt-end PR

Thanks for visiting 👍. If you have any questions feel free to ask 🙂

Copy link

@AmaduKamara AmaduKamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢 🟢 🟢

Hi @Lucash2022,

Good job working on the changes highlighted by the previous reviewer. 👍🏽

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉

Highlights:

✅ You used Gitflow correctly 👍🏽
✅ The Linter checks passed 👍🏽
✅ Rails and React apps work fine as expected 👍🏽
✅ The server renders random greetings 👍🏽
✅ Generates random greetings and are rendered on the Front-end 👍🏽

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants