Checkpoint manager tooltip fix and filename tooltip change #1200
Conversation
Change Filename tooltip to show relative path
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @RTHilton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses two issues related to tooltips in the checkpoint manager. First, it fixes tooltips not appearing in the lower checkpoint information panel by enabling hit testing on the ModelCardBottom element. Second, it changes the filename tooltip to display the relative path of the checkpoint file instead of the full filename.
Highlights
- Tooltip Fix: Tooltips are now visible in the lower checkpoint information panel.
- Relative Path: The filename tooltip now displays the relative path of the checkpoint file.
Changelog
- StabilityMatrix.Avalonia/Views/CheckpointsPage.axaml
- Line 629: Enabled hit testing for
ModelCardBottomto allow tooltips to appear. - Line 667: Changed the tooltip to display the
CheckpointFile.RelativePathinstead ofCheckpointFile.FileName.
- Line 629: Enabled hit testing for
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A tooltip's tale, a path made clear,
From full name's length to relative's near.
Hidden no more, in the panel below,
Information flows, for all to know.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses two issues in the CheckpointsPage view: tooltips not appearing in the lower checkpoint information panel and the filename tooltip displaying the full path instead of the relative path. The changes seem straightforward and effective in resolving these issues.
Summary of Findings
- Tooltip Visibility: The
IsHitTestVisibleproperty of theModelCardBottomelement was set toFalse, preventing tooltips from appearing. Changing it toTrueresolves this issue. - Filename Tooltip Content: The filename tooltip was displaying the full path. Changing the binding to
CheckpointFile.RelativePathensures that the tooltip displays the relative path, as intended.
Merge Readiness
The pull request appears to be ready for merging. The changes are small, focused, and address the described issues effectively. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
| Name="ModelCardBottom" | ||
| Padding="8" | ||
| CornerRadius="0,0,8,8" | ||
| IsHitTestVisible="False"> | ||
| IsHitTestVisible="True"> |
There was a problem hiding this comment.
Setting IsHitTestVisible to True makes the element able to receive hit test events, allowing the tooltip to be displayed. This fixes the issue of tooltips not appearing in the lower checkpoint information panel.
Consider adding a brief comment explaining why this property was changed to improve maintainability.
IsHitTestVisible="True" <!-- Allows tooltips to be displayed -->
| Foreground="{DynamicResource TextFillColorTertiaryBrush}" | ||
| Text="{Binding CheckpointFile.FileName}" | ||
| TextWrapping="NoWrap" | ||
| ToolTip.Tip="{Binding CheckpointFile.FileName}" /> | ||
| ToolTip.Tip="{Binding CheckpointFile.RelativePath}" /> |
There was a problem hiding this comment.
Changing the ToolTip.Tip binding from CheckpointFile.FileName to CheckpointFile.RelativePath ensures that the tooltip displays the relative path of the checkpoint file, providing a more user-friendly experience.
ToolTip.Tip="{Binding CheckpointFile.RelativePath}" />
Change Filename tooltip to show relative path
…atrix into tooltip-path
|
This unfortunately makes it so clicking the bottom 1/3 of the model card no longer brings up the details dialog. I played around with it and found myself liking a separate ℹ️icon that could hold this & possibly other details, like <avalonia:Icon Grid.Row="0"
Value="fa-solid fa-circle-info"
HorizontalAlignment="Right"
VerticalAlignment="Bottom"
Width="24"
Height="24"
Margin="0,0,8,8"
ZIndex="100"
ToolTip.Tip="{Binding CheckpointFile.RelativePath}"/>Right between the CheckBox and Button ~L552 |
Fix tooltips not appearing in lower checkpoint information panel
Change Filename tooltip to show relative path