Skip to content

Checkpoint manager tooltip fix and filename tooltip change #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions StabilityMatrix.Avalonia/Views/CheckpointsPage.axaml
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@
Name="ModelCardBottom"
Padding="8"
CornerRadius="0,0,8,8"
IsHitTestVisible="False">
IsHitTestVisible="True">
Comment on lines 626 to +629
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting IsHitTestVisible to True makes the element able to receive hit test events, allowing the tooltip to be displayed. This fixes the issue of tooltips not appearing in the lower checkpoint information panel.

Consider adding a brief comment explaining why this property was changed to improve maintainability.

                                        IsHitTestVisible="True" <!-- Allows tooltips to be displayed -->


<StackPanel>
<Grid ColumnDefinitions="*, Auto">
Expand Down Expand Up @@ -664,7 +664,7 @@
Foreground="{DynamicResource TextFillColorTertiaryBrush}"
Text="{Binding CheckpointFile.FileName}"
TextWrapping="NoWrap"
ToolTip.Tip="{Binding CheckpointFile.FileName}" />
ToolTip.Tip="{Binding CheckpointFile.RelativePath}" />
Comment on lines 664 to +667
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing the ToolTip.Tip binding from CheckpointFile.FileName to CheckpointFile.RelativePath ensures that the tooltip displays the relative path of the checkpoint file, providing a more user-friendly experience.

                                                ToolTip.Tip="{Binding CheckpointFile.RelativePath}" />


<TextBlock
MaxWidth="300"
Expand Down
Loading