Skip to content

Advance doc instead of offset in competitive iterator #14530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Advance doc instead of offset in competitive iterator #14530

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0da9f
advance doc instead of offset
gf2121 Apr 21, 2025
39c73b1
CHANGES
gf2121 Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,8 +533,8 @@ public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws IOExcept
if (disjunction == null) {
if (docsWithField != null) {
// we need to be absolutely sure that the iterator is at least at offset
if (docsWithField.docID() < offset) {
docsWithField.advance(offset);
if (docsWithField.docID() < doc) {
docsWithField.advance(doc);
Comment on lines -536 to +537
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. It should also go into 10.2, could you augment the changes entry for this bug fix to include this PR and such?

}
docsWithField.intoBitSet(upTo, bitSet, offset);
doc = docsWithField.docID();
Expand Down