Advance doc instead of offset in competitive iterator #14530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
benwtrent
reviewed
Apr 21, 2025
Comment on lines
-536
to
+537
| if (docsWithField.docID() < offset) { | ||
| docsWithField.advance(offset); | ||
| if (docsWithField.docID() < doc) { | ||
| docsWithField.advance(doc); |
There was a problem hiding this comment.
I think this is good. It should also go into 10.2, could you augment the changes entry for this bug fix to include this PR and such?
jpountz
approved these changes
Apr 21, 2025
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
asfgit
pushed a commit
that referenced
this pull request
Apr 22, 2025
asfgit
pushed a commit
that referenced
this pull request
Apr 22, 2025
jpountz
pushed a commit
to jpountz/lucene
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14523 (comment)
Should we include this in 10.2.1?