-
Notifications
You must be signed in to change notification settings - Fork 13
ci: Automate the release process #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
janbuchar
commented
Oct 23, 2024
- closes Automatically generate changelog from the commit messages #273
eed2d1a
to
e4077f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, but please update also:
.pre-commit-config.yaml
- rm legacy checks,Makefile
- rm legacy commands,- and
CONTRIBUTING.md
- basically just copy it from Crawlee and make necessary adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All our pipeline files so far follow a verb-based naming style (build_and_deploy_docs.yaml
, check_pr_title.yaml
, run_code_checks.yaml
, update_new_issue.yaml
). The release pipelines, however, are named release
and pre_release
. While I'm not insisting we have to use verb-style naming—I'm not sure what the best convention is—but please keep it consistent.
Release can be a verb, and I'd argue that the same holds for pre-release. As long as people know what to expect to find in those files (please tell me if that isn't the case), I wouldn't waste time on contemplating better names. |
Hah, correct. Leave it as it is then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks