Skip to content

ci: Automate the release process #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Conversation

janbuchar
Copy link
Contributor

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 23, 2024
@janbuchar janbuchar requested a review from vdusek October 23, 2024 08:46
@janbuchar janbuchar deployed to fork-pr-integration-tests October 23, 2024 08:47 — with GitHub Actions Active
@github-actions github-actions bot added this to the 101st sprint - Tooling team milestone Oct 23, 2024
@janbuchar janbuchar force-pushed the automated-release-process branch from eed2d1a to e4077f6 Compare October 29, 2024 13:05
@janbuchar janbuchar requested a review from B4nan October 29, 2024 13:05
@janbuchar janbuchar marked this pull request as ready for review October 29, 2024 13:06
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but please update also:

  • .pre-commit-config.yaml - rm legacy checks,
  • Makefile - rm legacy commands,
  • and CONTRIBUTING.md - basically just copy it from Crawlee and make necessary adjustments.

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All our pipeline files so far follow a verb-based naming style (build_and_deploy_docs.yaml, check_pr_title.yaml, run_code_checks.yaml, update_new_issue.yaml). The release pipelines, however, are named release and pre_release. While I'm not insisting we have to use verb-style naming—I'm not sure what the best convention is—but please keep it consistent.

@janbuchar
Copy link
Contributor Author

All our pipeline files so far follow a verb-based naming style (build_and_deploy_docs.yaml, check_pr_title.yaml, run_code_checks.yaml, update_new_issue.yaml). The release pipelines, however, are named release and pre_release. While I'm not insisting we have to use verb-style naming—I'm not sure what the best convention is—but please keep it consistent.

Release can be a verb, and I'd argue that the same holds for pre-release. As long as people know what to expect to find in those files (please tell me if that isn't the case), I wouldn't waste time on contemplating better names.

@vdusek
Copy link
Contributor

vdusek commented Oct 29, 2024

Release can be a verb, and I'd argue that the same holds for pre-release. As long as people know what to expect to find in those files (please tell me if that isn't the case), I wouldn't waste time on contemplating better names.

Hah, correct. Leave it as it is then.

@janbuchar janbuchar requested a review from vdusek October 30, 2024 09:54
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks

@janbuchar janbuchar merged commit 05cf887 into master Oct 30, 2024
24 checks passed
@janbuchar janbuchar deleted the automated-release-process branch October 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generate changelog from the commit messages
2 participants