-
Notifications
You must be signed in to change notification settings - Fork 298
Edit pass for consistency #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Than you for taking the time in contributing this PR 👏
It looks great, left some minor comments!
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
…rs/devcontainers.github.io into bamurtaugh/edit-pass
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Made one more change and resolved some comments! @samruddhikhandale if you're able to give a quick re-review and approval, that'd be fantastic 🚀 Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
Complete the edit pass mentioned in devcontainers/spec#293 (comment)
Main changes:
devcontainer.json
is a file type through `I'll similarly review https://github.com/devcontainers/spec to provide a similar edit pass, following the guidance established here.