b/sagemaker_image_version-use-version-in-id

[psantus]

Description

Makes aws_sagemaker_image_version identify the Image Versions by image name AND version number, to avoid ambiguous relationship between configuration and deployed resources.

Relations

Closes #42605

References

Output from Acceptance Testing

% export TF_ACC=1
export AWS_PROFILE=<REDACTED>
export SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=<REDACTED>.dkr.ecr.us-west-2.amazonaws.com/terraform-test:latest
cd ./internal/service/sagemaker
go test -v -run="TestAccSageMakerImageVersion_basic"

2025/05/14 00:49:30 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerImageVersion_basic
=== PAUSE TestAccSageMakerImageVersion_basic
=== CONT  TestAccSageMakerImageVersion_basic
--- PASS: TestAccSageMakerImageVersion_basic (92.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  96.813s

% go test -v -run="TestAccSageMakerImageVersion_full"

2025/05/14 00:51:53 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerImageVersion_full
=== PAUSE TestAccSageMakerImageVersion_full
=== CONT  TestAccSageMakerImageVersion_full
--- PASS: TestAccSageMakerImageVersion_full (107.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  111.822s

% go test -v -run="TestAccSageMakerImageVersion_disappears"

=== RUN   TestAccSageMakerImageVersion_disappears
=== PAUSE TestAccSageMakerImageVersion_disappears
=== CONT  TestAccSageMakerImageVersion_disappears
--- PASS: TestAccSageMakerImageVersion_disappears (88.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  92.487s

% go test -v -run="TestAccSageMakerImageVersion_Disappears_image"
2025/05/14 00:56:55 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerImageVersion_Disappears_image
=== PAUSE TestAccSageMakerImageVersion_Disappears_image
=== CONT  TestAccSageMakerImageVersion_Disappears_image
--- PASS: TestAccSageMakerImageVersion_Disappears_image (89.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  93.766s


...

% go test -v -run="TestParseImageVersionID"

2025/05/14 00:47:02 Initializing Terraform AWS Provider...
=== RUN   TestParseImageVersionID
=== RUN   TestParseImageVersionID/valid_ID_with_name_and_version
=== RUN   TestParseImageVersionID/invalid_ID_without_version
=== RUN   TestParseImageVersionID/invalid_ID_with_invalid_version
--- PASS: TestParseImageVersionID (0.00s)
    --- PASS: TestParseImageVersionID/valid_ID_with_name_and_version (0.00s)
    --- PASS: TestParseImageVersionID/invalid_ID_without_version (0.00s)
    --- PASS: TestParseImageVersionID/invalid_ID_with_invalid_version (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  4.001s



...

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

[psantus]

Probable duplicate of #42536 (that was only merged on release/6.0.0-beta, not yet on main)
ping @jar-b

[jar-b]

Duplicate of #42536

This fix will be available in the next V6 beta (v6.0.0-beta2) and generally available with v6.0.0 in Mid-June.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.