Skip to content

Fixes moving to cpu if needed in camera.py #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2025
Merged

Fixes moving to cpu if needed in camera.py #2176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6191ce
Update camera.py
renaudponcelet Mar 21, 2025
b7e484f
Update CONTRIBUTORS.md
renaudponcelet Mar 27, 2025
8f277fb
Merge branch 'main' into main
kellyguo11 Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ Guidelines for modifications:
* Qian Wan
* Qinxi Yu
* Rafael Wiltz
* Renaud Poncelet
* René Zurbrügg
* Ritvik Singh
* Rosario Scalise
Expand Down
2 changes: 1 addition & 1 deletion source/isaaclab/isaaclab/sensors/camera/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def __init__(self, cfg: CameraCfg):
rot_offset = convert_camera_frame_orientation_convention(
rot, origin=self.cfg.offset.convention, target="opengl"
)
rot_offset = rot_offset.squeeze(0).numpy()
rot_offset = rot_offset.squeeze(0).cpu().numpy()
# ensure vertical aperture is set, otherwise replace with default for squared pixels
if self.cfg.spawn.vertical_aperture is None:
self.cfg.spawn.vertical_aperture = self.cfg.spawn.horizontal_aperture * self.cfg.height / self.cfg.width
Expand Down