chore: patch and build freexl locally #5775
Conversation
shun2wang
changed the title
shun2wang
force-pushed
the
conan_recipe
branch
3 times, most recently
from
296ac83 to
4bc77ab
Compare
|
Ive cloned your repo with conan stuff to jasp-stats |
|
Great! I'm also tring to get ReadStat work with conan too, if done then we can put it into repo. |
shun2wang
force-pushed
the
conan_recipe
branch
from
4bc77ab to
349e365
Compare
shun2wang
changed the title
|
It's ready for review, for readStat I had pull a recipe PR for conan upstream: conan-io/conan-center-index#25181 But it's not ready for msvc now. I'm afraid we don't have to wait for it. |
| execute_process( | ||
| COMMAND_ECHO STDOUT | ||
| WORKING_DIRECTORY ${CMAKE_BINARY_DIR} | ||
| COMMAND | ||
| conan install ${CONAN_FILE_PATH} --output-folder=${CMAKE_BINARY_DIR}/conan_build | ||
| conan install ${CONAN_FILE_PATH} --output-folder=${CMAKE_BINARY_DIR}/_conan_build |
There was a problem hiding this comment.
because I think all dependencies build dir should with "_" just like others.
There was a problem hiding this comment.
this is minor but for just for the uniformity...
|
Did you now also implement macos and linux? |
|
As bruno points out windows users are most likely to be using excel, so we can probably also just merge this without it being fixed on macos and linux. Ive also double checked the jasp-stats/conan-recipes and it looks good to me. I dont understand why you want to rename the _conan_build folder though? |
|
I don't have a MacOS so I can't implement it but it is easy because just some cmake works. on Linux people should clone and build freexl by self on local, @RensDofferhoff should do some work on flatpak buid env I think. |
This is a bit hacky but conan has no built-in local patching solution.
@boutinb @JorisGoosen Please clone my repo as a JASP organization repo and then we can maintain our own patched version of freexl.
TODO: