gh-132671: Do not match host+port with proxy bypass macOS rules, match host only. #132672
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-sh
commented
Apr 18, 2025
•
nikola-sh
commented
- Issue: urllib doesn't respect macOS bypass proxy rules if URL contains port #132671
…if URL contains port Do not match host+port with proxy bypass rules, match host only. Issue python#132671
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
| @@ -0,0 +1 @@ | |||
| Fix issue where system proxy bypass configuration doesn't work with URL with port part. | |||
There was a problem hiding this comment.
- We need some context about what module/function is actually being fixed.
- "system proxy bypass configuration doesn't work" is a bit wordy.
Suggested change
| Fix issue where system proxy bypass configuration doesn't work with URL with port part. | |
| Fix proxy bypass on URLs with a port in :mod:`urllib.request`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.