Skip to content

gh-132671: Do not match host+port with proxy bypass macOS rules, match host only. #132672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −7
Open

gh-132671: Do not match host+port with proxy bypass macOS rules, match host only. #132672

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c50e1c2
gh-132671: Fix urllib doesn't respect macOS bypass proxy rules if URL…
nikola-sh Apr 18, 2025
5fca898
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 18, 2025
fa20425
test
nikola-sh Apr 22, 2025
a6dadb1
fix news
nikola-sh Apr 22, 2025
4ea39ff
Merge branch 'main' into patch-1
ZeroIntensity Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/urllib/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,7 @@ def ip2num(ipAddr):
if (hostIP >> mask) == (base >> mask):
return True

elif fnmatch(host, value):
elif fnmatch(hostonly, value):
return True

return False
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/macOS/2025-04-18-06-36-46.gh-issue-132671.FRLb6i.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix issue where system proxy bypass configuration doesn't work with URL with port part.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We need some context about what module/function is actually being fixed.
  • "system proxy bypass configuration doesn't work" is a bit wordy.
Suggested change
Fix issue where system proxy bypass configuration doesn't work with URL with port part.
Fix proxy bypass on URLs with a port in :mod:`urllib.request`.

Loading