feat(onboarding): data source tenant external id #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cgeers
commented
May 21, 2024
cgeers
commented
- adds external id as data source for use by sysdig tenants
cgeers
force-pushed
the
feat/onboarding/data_sources
branch
from
20f2922 to
e6603c0
Compare
|
We will need a docs change as well in this PR, since new data sources are being added. |
* adds external id as data source for use by sysdig tenants
cgeers
force-pushed
the
feat/onboarding/data_sources
branch
from
e6603c0 to
f83e9df
Compare
ravinadhruve10
approved these changes
May 28, 2024
There was a problem hiding this comment.
Changes look good. However, CI is failing with below :-
- test fails in the CI pipeline
- we would need docs change as well since new data sources are being added
- lint fix
can we please check these?
cgeers
force-pushed
the
feat/onboarding/data_sources
branch
from
3da72f4 to
eaac319
Compare
ravinadhruve10
approved these changes
May 29, 2024
dbonf
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.