Skip to content

feat(onboarding): data source tenant external id #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,16 @@ import (
"time"

"github.com/aws/aws-sdk-go/aws/arn"
v2 "github.com/draios/terraform-provider-sysdig/sysdig/internal/client/v2"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
)

func getSecureOnboardingClient(c SysdigClients) (v2.OnboardingSecureInterface, error) {
return c.sysdigSecureClientV2()
}

func dataSourceSysdigSecureTrustedCloudIdentity() *schema.Resource {
timeout := 5 * time.Minute

Expand Down Expand Up @@ -53,7 +58,7 @@ func dataSourceSysdigSecureTrustedCloudIdentity() *schema.Resource {

// Retrieves the information of a resource form the file and loads it in Terraform
func dataSourceSysdigSecureTrustedCloudIdentityRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
client, err := getSecureCloudAccountClient(meta.(SysdigClients))
client, err := getSecureOnboardingClient(meta.(SysdigClients))
if err != nil {
return diag.FromErr(err)
}
Expand Down Expand Up @@ -88,3 +93,43 @@ func dataSourceSysdigSecureTrustedCloudIdentityRead(ctx context.Context, d *sche
}
return nil
}

func dataSourceSysdigSecureTenantExternalID() *schema.Resource {
timeout := 5 * time.Minute

return &schema.Resource{
ReadContext: dataSourceSysdigSecureTenantExternalIDRead,

Timeouts: &schema.ResourceTimeout{
Read: schema.DefaultTimeout(timeout),
},

Schema: map[string]*schema.Schema{
"external_id": {
Type: schema.TypeString,
Computed: true,
},
},
}
}

// Retrieves the information of a resource form the file and loads it in Terraform
func dataSourceSysdigSecureTenantExternalIDRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
client, err := getSecureOnboardingClient(meta.(SysdigClients))
if err != nil {
return diag.FromErr(err)
}

externalId, err := client.GetTenantExternalIDSecure(ctx)
if err != nil {
return diag.FromErr(err)
}

d.SetId(externalId)
err = d.Set("external_id", externalId)
if err != nil {
return diag.FromErr(err)
}

return nil
}
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,23 @@ data "sysdig_secure_trusted_cloud_identity" "trusted_identity" {
}
`
}

func TestAccTenantExternalIDDataSource(t *testing.T) {
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
if v := os.Getenv("SYSDIG_SECURE_API_TOKEN"); v == "" {
t.Fatal("SYSDIG_SECURE_API_TOKEN must be set for acceptance tests")
}
},
ProviderFactories: map[string]func() (*schema.Provider, error){
"sysdig": func() (*schema.Provider, error) {
return sysdig.Provider(), nil
},
},
Steps: []resource.TestStep{
{
Config: `data "sysdig_secure_tenant_external_id" "external_id" {}`,
},
},
})
}
20 changes: 0 additions & 20 deletions sysdig/internal/client/v2/cloud_account.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const (
cloudAccountsWithExternalIDPath = "%s/api/cloud/v2/accounts?includeExternalID=true&upsert=true"
cloudAccountPath = "%s/api/cloud/v2/accounts/%s"
cloudAccountWithExternalIDPath = "%s/api/cloud/v2/accounts/%s?includeExternalID=true"
trustedCloudIdentityPath = "%s/api/cloud/v2/%s/trustedIdentity"
providersPath = "%v/api/v2/providers"
)

Expand All @@ -21,7 +20,6 @@ type CloudAccountSecureInterface interface {
GetCloudAccountSecure(ctx context.Context, accountID string) (*CloudAccountSecure, error)
DeleteCloudAccountSecure(ctx context.Context, accountID string) error
UpdateCloudAccountSecure(ctx context.Context, accountID string, cloudAccount *CloudAccountSecure) (*CloudAccountSecure, error)
GetTrustedCloudIdentitySecure(ctx context.Context, provider string) (string, error)
}

type CloudAccountMonitorInterface interface {
Expand Down Expand Up @@ -99,20 +97,6 @@ func (client *Client) UpdateCloudAccountSecure(ctx context.Context, accountID st
return Unmarshal[*CloudAccountSecure](response.Body)
}

func (client *Client) GetTrustedCloudIdentitySecure(ctx context.Context, provider string) (string, error) {
response, err := client.requester.Request(ctx, http.MethodGet, client.trustedCloudIdentityURL(provider), nil)
if err != nil {
return "", err
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return "", client.ErrorFromResponse(response)
}

return Unmarshal[string](response.Body)
}

func (client *Client) cloudAccountsURL(includeExternalID bool) string {
if includeExternalID {
return fmt.Sprintf(cloudAccountsWithExternalIDPath, client.config.url)
Expand All @@ -127,10 +111,6 @@ func (client *Client) cloudAccountURL(accountID string, includeExternalID bool)
return fmt.Sprintf(cloudAccountPath, client.config.url, accountID)
}

func (client *Client) trustedCloudIdentityURL(provider string) string {
return fmt.Sprintf(trustedCloudIdentityPath, client.config.url, provider)
}

func (client *Client) CreateCloudAccountMonitor(ctx context.Context, provider *CloudAccountMonitor) (*CloudAccountMonitor, error) {
payload, err := Marshal(provider)
if err != nil {
Expand Down
46 changes: 46 additions & 0 deletions sysdig/internal/client/v2/onboarding.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package v2

import (
"context"
"fmt"
"net/http"
)

const (
onboardingTrustedIdentityPath = "%s/api/secure/onboarding/v2/trustedIdentity?provider=%s"
onboardingTenantExternaIDPath = "%s/api/secure/onboarding/v2/externalID"
)

type OnboardingSecureInterface interface {
Base
GetTrustedCloudIdentitySecure(ctx context.Context, provider string) (string, error)
GetTenantExternalIDSecure(ctx context.Context) (string, error)
}

func (client *Client) GetTrustedCloudIdentitySecure(ctx context.Context, provider string) (string, error) {
response, err := client.requester.Request(ctx, http.MethodGet, fmt.Sprintf(onboardingTrustedIdentityPath, client.config.url, provider), nil)
if err != nil {
return "", err
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return "", client.ErrorFromResponse(response)
}

return Unmarshal[string](response.Body)
}

func (client *Client) GetTenantExternalIDSecure(ctx context.Context) (string, error) {
response, err := client.requester.Request(ctx, http.MethodGet, fmt.Sprintf(onboardingTenantExternaIDPath, client.config.url), nil)
if err != nil {
return "", err
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return "", client.ErrorFromResponse(response)
}

return Unmarshal[string](response.Body)
}
1 change: 1 addition & 0 deletions sysdig/internal/client/v2/sysdig.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ type SysdigSecure interface {
OrganizationSecureInterface
CloudauthAccountComponentSecureInterface
CloudauthAccountFeatureSecureInterface
OnboardingSecureInterface
}

func (sr *SysdigRequest) Request(ctx context.Context, method string, url string, payload io.Reader) (*http.Response, error) {
Expand Down
1 change: 1 addition & 0 deletions sysdig/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ func (p *SysdigProvider) Provider() *schema.Provider {
},
DataSourcesMap: map[string]*schema.Resource{
"sysdig_secure_trusted_cloud_identity": dataSourceSysdigSecureTrustedCloudIdentity(),
"sysdig_secure_tenant_external_id": dataSourceSysdigSecureTenantExternalID(),
"sysdig_secure_notification_channel": dataSourceSysdigSecureNotificationChannel(),
"sysdig_secure_notification_channel_pagerduty": dataSourceSysdigSecureNotificationChannelPagerduty(),
"sysdig_secure_notification_channel_email": dataSourceSysdigSecureNotificationChannelEmail(),
Expand Down
Loading