r/aws_sagemaker_image_version: read correct version after create

[jar-b]

Description

Previously the read operation would always retrieve the latest image version matching the image_name argument, rather than tracking the version created by a given resource instance. This change updates the id attribute to a comma-delimited string concatenating image_name and version, enabling subsequent read operations to correctly match the version created by this resource, and supporting import of existing versions which are not the most recently created. It also fixes issues observed when managing multiple image versions of the same name in a single workspace.

Relations

Closes #40597
Relates #41101

Output from Acceptance Testing

% SAGEMAKER_IMAGE_VERSION_BASE_IMAGE="<redacted>" make testacc PKG=sagemaker TESTS=TestAccSageMakerImageVersion_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerImageVersion_'  -timeout 360m -vet=off
2025/05/08 10:39:43 Initializing Terraform AWS Provider...

--- PASS: TestAccSageMakerImageVersion_Disappears_image (80.09s)
--- PASS: TestAccSageMakerImageVersion_basic (82.82s)
--- PASS: TestAccSageMakerImageVersion_disappears (84.49s)
--- PASS: TestAccSageMakerImageVersion_multiple (88.17s)
--- PASS: TestAccSageMakerImageVersion_update (91.47s)
--- PASS: TestAccSageMakerImageVersion_upgrade_V5_98_0 (102.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  108.081s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

[ewbankkit]

LGTM 🚀.

% SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=... make testacc TESTARGS='-run=TestAccSageMakerImageVersion_' PKG=sagemaker ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 3  -run=TestAccSageMakerImageVersion_ -timeout 360m -vet=off
2025/05/12 11:59:41 Creating Terraform AWS Provider (SDKv2-style)...
2025/05/12 11:59:41 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSageMakerImageVersion_basic
=== PAUSE TestAccSageMakerImageVersion_basic
=== RUN   TestAccSageMakerImageVersion_update
=== PAUSE TestAccSageMakerImageVersion_update
=== RUN   TestAccSageMakerImageVersion_disappears
=== PAUSE TestAccSageMakerImageVersion_disappears
=== RUN   TestAccSageMakerImageVersion_Disappears_image
=== PAUSE TestAccSageMakerImageVersion_Disappears_image
=== RUN   TestAccSageMakerImageVersion_multiple
=== PAUSE TestAccSageMakerImageVersion_multiple
=== RUN   TestAccSageMakerImageVersion_upgrade_V5_98_0
=== PAUSE TestAccSageMakerImageVersion_upgrade_V5_98_0
=== CONT  TestAccSageMakerImageVersion_basic
=== CONT  TestAccSageMakerImageVersion_Disappears_image
=== CONT  TestAccSageMakerImageVersion_disappears
--- PASS: TestAccSageMakerImageVersion_disappears (77.47s)
=== CONT  TestAccSageMakerImageVersion_update
--- PASS: TestAccSageMakerImageVersion_basic (79.39s)
=== CONT  TestAccSageMakerImageVersion_upgrade_V5_98_0
--- PASS: TestAccSageMakerImageVersion_Disappears_image (79.95s)
=== CONT  TestAccSageMakerImageVersion_multiple
--- PASS: TestAccSageMakerImageVersion_multiple (81.79s)
--- PASS: TestAccSageMakerImageVersion_update (88.92s)
--- PASS: TestAccSageMakerImageVersion_upgrade_V5_98_0 (111.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	195.041s

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[psantus]

@jar-b any way you could backport this to a 5.x version? I need it fast for a customer project !

[jar-b]

Unfortunately not. In this case we explicitly opted to make this change in a major version given the breakage in the format of the id attribute. Backporting would result in that breakage being present across a V5 minor version.

Depending on how quickly this fix is required you could use the next V6 beta (v6.0.0-beta2, currently slated for release on 5/22), or build directly from source using the release/6.0.0-beta branch and set up provider development overrides until a formal release is available.